Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Directory Go Into node #2702

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Mar 21, 2024

Closes #2519
Closes #606

This adds the last node from #2519. As before I made a few changes:

  • I named it "Directory Go Into" to be consistent with the "Directory Go Up" node.
  • I added a few optional folder inputs, so users can join multiple folders without needing to know that / and \ are usually used to denote this.
  • More path validation: no invalid characters and absolute paths.

The output type of this node is kind of insane because Navi doesn't have early returns.

image

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Damn the nesting on the Navi type is so gross

@joeyballentine joeyballentine merged commit f96aa3b into chaiNNer-org:main Mar 21, 2024
17 checks passed
@RunDevelopment RunDevelopment deleted the dir-go-into branch March 21, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory helper nodes
2 participants